Filter lexical siblings from prefixed listings - #6713
Merged
Conversation
Mallets
marked this pull request as ready for review
August 20, 2026 10:15
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07111fbf73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Filter byte-prefix lexical siblings while surfacing objects returned outside the storage prefix.
PSeitz-dd
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From an independent codex CI:
PrefixStorage::listnow filters lexical siblings outside its component-level storage root before stripping the prefix. This prevents byte-prefix backends such as S3 from failing an entire listing page when they return a lexical sibling (for example,indexes-old/objectwhile listingindexes). Unrelated out-of-prefix paths still produce an internal error so backend contract violations are not hidden.Adds regression tests for both lexical siblings and unrelated paths.
Follow-up to #6705.
How was this PR tested?
make fmtcargo check -p quickwit-storage --libcargo nextest run -p quickwit-storage prefix_storage --retries 1; test compilation is currently blocked onmainbyaws-smithy-http-clientenablingserde_json/preserve_order, which triggers the existing compile-time assertion inquickwit-storage/src/lib.rs.